Deprecated parameter alerts #673
Open
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsyth2
commented
Feb 4, 2025
Collaborator
Author
forsyth2
left a comment
forsyth2
left a comment
There was a problem hiding this comment.
@chengzhuzhang This is ready for review.
Comment on lines
+337
to
+338
| if present_parameters: | ||
| raise DeprecatedParameterError(present_parameters) |
Collaborator
Author
There was a problem hiding this comment.
We could also just do a warning, but I figured an error is more likely to get the user's attention.
Collaborator
There was a problem hiding this comment.
does ts_fmt a no-op or raise error before this change?
Collaborator
Author
There was a problem hiding this comment.
on main, it just won't get used by anything. That is, if a user sets it thinking it's useful, they'll get no indication (either warning or error) that it's not actually useful. (Confirmed with cfg in #677).
7 tasks
Collaborator
Author
|
@chengzhuzhang Did we decide we want these changes? If so, I'll go ahed and merge. |
forsyth2
added
the
semver: small improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Objectives:
Issue resolution:
Select one: This pull request is...
Small Change